Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix typo in data_pipeline #220

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Fix typo in data_pipeline #220

merged 1 commit into from
Apr 17, 2021

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

Fix a small typo in DataPipeline.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #220 (94093b1) into master (14502b0) will decrease coverage by 3.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   86.56%   82.81%   -3.75%     
==========================================
  Files          57       57              
  Lines        2747     2747              
==========================================
- Hits         2378     2275     -103     
- Misses        369      472     +103     
Flag Coverage Δ
unittests 82.81% <100.00%> (-3.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/data/data_pipeline.py 88.04% <100.00%> (ø)
flash/text/seq2seq/core/data.py 42.62% <0.00%> (-40.99%) ⬇️
flash/text/classification/data.py 40.90% <0.00%> (-40.91%) ⬇️
flash/text/classification/model.py 62.50% <0.00%> (-31.25%) ⬇️
flash/text/seq2seq/summarization/data.py 57.14% <0.00%> (-28.58%) ⬇️
flash/text/seq2seq/translation/model.py 55.55% <0.00%> (-16.67%) ⬇️
flash/text/seq2seq/summarization/metric.py 84.48% <0.00%> (-12.07%) ⬇️
flash/text/seq2seq/translation/data.py 80.00% <0.00%> (-10.00%) ⬇️
flash/text/seq2seq/core/model.py 61.53% <0.00%> (-6.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14502b0...94093b1. Read the comment docs.

@Borda Borda enabled auto-merge (squash) April 16, 2021 21:26
@Borda Borda disabled auto-merge April 17, 2021 20:32
@Borda Borda merged commit 4e68cc0 into master Apr 17, 2021
@Borda Borda deleted the typo/fix-postprocess branch April 17, 2021 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants