Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Explicitly add fsspec requirement to fix rtd build #1395

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jul 15, 2022

What does this PR do?

RTD build is failing because it doesn't know to mock out the fsspec library as it's not explicitly given in our requirements. This fixes it.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the documentation Improvements or additions to documentation label Jul 15, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone Jul 15, 2022
@ethanwharris ethanwharris marked this pull request as ready for review July 15, 2022 10:53
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1395 (afc19a3) into master (95e19d3) will decrease coverage by 7.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   92.90%   85.06%   -7.84%     
==========================================
  Files         285      285              
  Lines       12778    12778              
==========================================
- Hits        11871    10870    -1001     
- Misses        907     1908    +1001     
Flag Coverage Δ
unittests 85.06% <ø> (-7.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lash/image/embedding/vissl/transforms/utilities.py 15.15% <0.00%> (-84.85%) ⬇️
flash/image/embedding/heads/vissl_heads.py 35.29% <0.00%> (-64.71%) ⬇️
flash/image/embedding/losses/vissl_losses.py 37.50% <0.00%> (-62.50%) ⬇️
flash/image/embedding/vissl/adapter.py 31.63% <0.00%> (-62.25%) ⬇️
flash/image/detection/input.py 38.88% <0.00%> (-61.12%) ⬇️
...age/face_detection/backbones/fastface_backbones.py 42.10% <0.00%> (-57.90%) ⬇️
flash/image/face_detection/model.py 36.84% <0.00%> (-55.27%) ⬇️
flash/image/face_detection/input_transform.py 46.87% <0.00%> (-53.13%) ⬇️
flash/image/face_detection/output_transform.py 47.05% <0.00%> (-52.95%) ⬇️
flash/image/detection/output.py 43.47% <0.00%> (-52.18%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e19d3...afc19a3. Read the comment docs.

@ethanwharris ethanwharris merged commit 3e4c8bb into master Jul 15, 2022
@ethanwharris ethanwharris deleted the docs/fix_build branch July 15, 2022 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants