Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix package install CI #1109

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Fix package install CI #1109

merged 2 commits into from
Jan 11, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1109 (96ece20) into master (77fda7b) will decrease coverage by 6.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
- Coverage   88.42%   82.33%   -6.09%     
==========================================
  Files         284      284              
  Lines       12876    12876              
==========================================
- Hits        11386    10602     -784     
- Misses       1490     2274     +784     
Flag Coverage Δ
unittests 82.33% <ø> (-6.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 17.83% <0.00%> (-73.89%) ⬇️
...lash/image/embedding/vissl/transforms/multicrop.py 27.27% <0.00%> (-69.70%) ⬇️
...lash/image/embedding/vissl/transforms/utilities.py 14.63% <0.00%> (-68.30%) ⬇️
flash/image/detection/output.py 30.61% <0.00%> (-65.31%) ⬇️
flash/image/embedding/heads/vissl_heads.py 36.36% <0.00%> (-63.64%) ⬇️
flash/image/detection/input.py 35.61% <0.00%> (-61.65%) ⬇️
flash/core/integrations/icevision/backbones.py 33.33% <0.00%> (-60.01%) ⬇️
flash/core/integrations/icevision/data.py 34.88% <0.00%> (-58.14%) ⬇️
flash/image/embedding/vissl/adapter.py 31.76% <0.00%> (-56.48%) ⬇️
flash/image/embedding/losses/vissl_losses.py 41.66% <0.00%> (-50.00%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fda7b...96ece20. Read the comment docs.

@ethanwharris ethanwharris merged commit 54d641d into master Jan 11, 2022
@ethanwharris ethanwharris deleted the bugfix/install branch January 11, 2022 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant