Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Some fixes for compatibility with PL master #1106

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1106 (eb47dc5) into master (3b2d868) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files         281      281           
  Lines       12816    12816           
=======================================
  Hits        11005    11005           
  Misses       1811     1811           
Flag Coverage Δ
unittests 85.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/io/input_transform.py 73.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b2d868...eb47dc5. Read the comment docs.

@Borda Borda added the bug / fix Something isn't working label Jan 7, 2022
@ethanwharris ethanwharris merged commit 21a9d7f into master Jan 7, 2022
@ethanwharris ethanwharris deleted the bugfix/tabular_pl_master branch January 7, 2022 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants