Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update QA to new inputs and datamodule #1045

Merged
merged 8 commits into from
Dec 9, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #964
Fixes #955

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks dope !

flash/text/question_answering/data.py Show resolved Hide resolved
flash/text/question_answering/input.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1045 (123c6fd) into master (d1e3c09) will increase coverage by 0.14%.
The diff coverage is 96.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   86.66%   86.80%   +0.14%     
==========================================
  Files         272      275       +3     
  Lines       13885    13797      -88     
==========================================
- Hits        12033    11977      -56     
+ Misses       1852     1820      -32     
Flag Coverage Δ
unittests 86.80% <96.13%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/cli.py 100.00% <ø> (ø)
flash/text/question_answering/output_transform.py 63.63% <63.63%> (ø)
flash/text/question_answering/data.py 93.10% <92.30%> (+6.26%) ⬆️
flash/text/question_answering/input.py 98.17% <98.17%> (ø)
flash/core/integrations/transformers/transforms.py 100.00% <100.00%> (ø)
flash/text/question_answering/input_transform.py 100.00% <100.00%> (ø)
flash/text/question_answering/model.py 91.15% <100.00%> (+0.12%) ⬆️
flash/core/utilities/stages.py 73.91% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e3c09...123c6fd. Read the comment docs.

@ethanwharris ethanwharris merged commit 75a14b1 into master Dec 9, 2021
@ethanwharris ethanwharris deleted the feature/qa_inputs branch December 9, 2021 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard text inputs to new Input object Onboard old inputs to new Input object
2 participants