-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple DataModules from Models - SemSegment #332
Decouple DataModules from Models - SemSegment #332
Conversation
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 82.32% 82.40% +0.07%
==========================================
Files 100 100
Lines 5602 5620 +18
==========================================
+ Hits 4612 4631 +19
+ Misses 990 989 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
037434a
to
5263a5f
Compare
5263a5f
to
58d944b
Compare
@akihironitta seems that some tests are not passing, mind have a look... :] |
What does this PR do?
This PR is a follow up of #206 and fixes #207.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃