Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_dependency_min_version_spec function #62

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Added get_dependency_min_version_spec function #62

merged 1 commit into from
Oct 27, 2022

Conversation

mauvilsa
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [n/a] Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #59

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mauvilsa mauvilsa marked this pull request as ready for review October 18, 2022 15:21
@mauvilsa mauvilsa changed the title Added get_minimum_dependency_version function Added get_dependency_min_version_spec function Oct 19, 2022
@mauvilsa mauvilsa requested review from carmocca and Borda and removed request for carmocca and Borda October 19, 2022 20:36
@Borda Borda enabled auto-merge (squash) October 22, 2022 08:38
@Borda Borda merged commit c3bcba0 into Lightning-AI:main Oct 27, 2022
@mauvilsa mauvilsa deleted the get-min-dep-version branch October 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to get minumum version of a dependency of a package
3 participants