Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core and dev directories #28

Merged
merged 7 commits into from
Sep 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@

/.github/CODEOWNERS @borda
/setup.py @borda

/src/lightning_utilities/core @borda @carmocca
/tests/unittests/core @borda @carmocca
2 changes: 1 addition & 1 deletion .github/workflows/ci-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
if: matrix.requires == 'oldest'
run: |
pip install -e .
python -m lightning_utilities requirements set-oldest
python -m lightning_utilities.dev requirements set-oldest

- uses: ./.github/actions/cache
with:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ pip install lightning_utilities
__Usage:__

```bash
python -m lightning_utilities [group] [command]
python -m lightning_utilities.dev [group] [command]
```

<details>
Expand All @@ -92,7 +92,7 @@ codecov>=2.1
pytest>=6.0
pytest-cov
pytest-timeout
$ python -m lightning_utilities requirements set-oldest
$ python -m lightning_utilities.dev requirements set-oldest
$ cat requirements/test.txt
coverage==5.0
codecov==2.1
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _load_py_module(fname, pkg="lightning_utilities"):
long_description_content_type="text/markdown",
include_package_data=True,
zip_safe=False,
keywords=["DevOps", "CI/CD"],
keywords=["Utilities", "DevOps", "CI/CD"],
python_requires=">=3.7",
setup_requires=[],
install_requires=requirements,
Expand Down
Empty file.
Empty file.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import fire

from lightning_utilities.dependencies import prune_pkgs_in_requirements, replace_oldest_ver
from lightning_utilities.dev.dependencies import prune_pkgs_in_requirements, replace_oldest_ver


def main() -> None:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import operator

from lightning_utilities.imports import compare_version, module_available, RequirementCache
from lightning_utilities.core.imports import compare_version, module_available, RequirementCache


def test_module_exists():
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pathlib import Path

from lightning_utilities.dependencies import prune_pkgs_in_requirements, replace_oldest_ver
from lightning_utilities.dev.dependencies import prune_pkgs_in_requirements, replace_oldest_ver

_PATH_ROOT = Path(__file__).parent.parent.parent

Expand Down