Skip to content

Commit

Permalink
Provide installation instructions in RequirementCache error message (
Browse files Browse the repository at this point in the history
  • Loading branch information
carmocca authored Sep 19, 2022
1 parent 89880a1 commit 86e9e48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/lightning_utilities/core/imports.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _check_requirement(self) -> None:
self.message = f"Requirement {self.requirement!r} met"
except Exception as ex:
self.available = False
self.message = f"Requirement {self.requirement!r} not met, {ex.__class__.__name__}: {ex}"
self.message = f"{ex.__class__.__name__}: {ex}. HINT: Try running `pip install -U {self.requirement!r}`"

def __bool__(self) -> bool:
self._check_requirement()
Expand Down
2 changes: 1 addition & 1 deletion tests/unittests/core/test_imports.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ def test_requirement_cache():

assert RequirementCache(f"pytest>={pytest.__version__}")
assert not RequirementCache(f"pytest<{pytest.__version__}")
assert "Requirement '-' not met" in str(RequirementCache("-"))
assert "pip install -U '-'" in str(RequirementCache("-"))

0 comments on commit 86e9e48

Please sign in to comment.