Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corner case when single empty pred is provided to detection IOU metric #2780

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 14, 2024

What does this PR do?

Fixes #2778

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2780.org.readthedocs.build/en/2780/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Oct 14, 2024
@SkafteNicki SkafteNicki added this to the v1.4.x milestone Oct 14, 2024
@SkafteNicki SkafteNicki self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36%. Comparing base (b1f4db2) to head (89bc170).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2780     +/-   ##
========================================
- Coverage      70%     36%    -34%     
========================================
  Files         336     336             
  Lines       18229   18231      +2     
========================================
- Hits        12705    6569   -6136     
- Misses       5524   11662   +6138     

@mergify mergify bot added the ready label Oct 15, 2024
@Borda Borda merged commit a8cbae7 into master Oct 15, 2024
60 of 62 checks passed
@Borda Borda deleted the bugfix/iou_single_empty_pred branch October 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Detect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result of IoU is Nan when there is empty item in preds.
2 participants