Fix/macro recall ignore index multiclass #2737
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2441
Details
Did you have fun?
Yes
Issue:
ignore_index
information is not being properly propagated to the final averaging step i.e. the_adjust_weights_safe_divide
function doesn't know that which class should be ignored.Solution:
ignore_index
information is preserved throughout the entire process, making sure it is correctly passed through all intermediate steps up to the final averaging stage i.e._adjust_weights_safe_divide
function ._adjust_weights_safe_divide
function to accept an additionalignore_index
parameter, which is passed through the_precision_recall_reduce
function, called in thecompute
method of theMulticlassRecall
class. This change adjusts the weights in the_adjust_weights_safe_divide
function, setting the weight of the ignored class to 0.📚 Documentation preview 📚: https://torchmetrics--2737.org.readthedocs.build/en/2737/