Add Spatial Correlation Coefficient (SCC) metric #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoseinAkbarzadeh
requested review from
lantiga,
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
github-actions
bot
added
documentation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2248 +/- ##
========================================
- Coverage 87% 41% -46%
========================================
Files 298 300 +2
Lines 16854 16969 +115
========================================
- Hits 14634 6970 -7664
- Misses 2220 9999 +7779 |
SkafteNicki
reviewed
Nov 29, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@SkafteNicki I made some modifications to correct the problems. Would you mind taking another look ? |
Borda
approved these changes
Dec 4, 2023
…n in scc functional interface
|
Sorry, since the last changes I made, I got no new feedback and I don't know whether the PR is rejected. @Borda @SkafteNicki would you mind taking a look at this PR and guide me what should I do next ? Is there something that I'm missing ? |
|
@HoseinAkbarzadeh sorry for the delay from my part. PR is not rejected, we have just been busy on other fronts. Let me try to get this merged within the next couple of days |
Co-authored-by: Jirka Borovec <[email protected]>
SkafteNicki
approved these changes
Dec 20, 2023
Borda
approved these changes
Dec 21, 2023
Borda
reviewed
Dec 21, 2023
Borda
reviewed
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds spatial correlation coefficient (scc) according to #799
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2248.org.readthedocs.build/en/2248/