Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning on small input in PearsonCorrCoef #1926

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 17, 2023

What does this PR do?

Fixes #1922

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1926.org.readthedocs.build/en/1926/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Jul 17, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1926 (14b79c4) into master (eda473f) will decrease coverage by 45%.
The diff coverage is 79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1926     +/-   ##
========================================
- Coverage      85%     40%    -45%     
========================================
  Files         263     263             
  Lines       15061   15087     +26     
========================================
- Hits        12809    5982   -6827     
- Misses       2252    9105   +6853     

@Borda Borda enabled auto-merge (squash) July 18, 2023 08:06
@mergify mergify bot added the ready label Jul 18, 2023
@Borda Borda merged commit 44afba6 into master Jul 24, 2023
@Borda Borda deleted the feature/pearson_warning_on_small_var branch July 24, 2023 20:51
Borda pushed a commit that referenced this pull request Aug 1, 2023
Borda pushed a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting from half precision to bfloat16 in Pearson correlation coefficient cause numerical errors
3 participants