Multiclass-jaccard: fix off-by-one issue when ignore_index = num_classes + 1 #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmeinke
changed the title
martinmeinke
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
SkafteNicki
approved these changes
Jun 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
========================================
- Coverage 87% 51% -37%
========================================
Files 256 256
Lines 14365 14365
========================================
- Hits 12563 7274 -5289
- Misses 1802 7091 +5289 |
…ithub.com/martinmeinke/torchmetrics into bugfix/multiclass_jaccard_ignore_off_by_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1861
If I interpret the code correctly, the condition determines whether the
ignore_indexlies withinnum_classes, in which case it is off-by-one.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1860.org.readthedocs.build/en/1860/