New metric: Precision at fixed recall #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…/PyTorchLightning/metrics into metric/precision_at_fixed_recall
Borda
approved these changes
Apr 3, 2023
|
@SkafteNicki seems that the docstring examples do not return the correct values... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
========================================
- Coverage 88% 52% -36%
========================================
Files 236 238 +2
Lines 13200 13331 +131
========================================
- Hits 11618 6928 -4690
- Misses 1582 6403 +4821 |
justusschock
approved these changes
Apr 13, 2023
|
@SkafteNicki could you pls check the typing? 🐿️ |
|
@Borda, thanks for this awesome PR! Will it be introduced in |
will be in v1.0.0 and we can do RC on beginning of next week for early testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1678
Adds
PrecisionAtFixedRecallnew metric. It is basically a copy-paste ofRecallAtFixedPrecisionwith the logic turned around.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃