Explicit mention that 1 is the positive class in docs #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Dec 9, 2022
justusschock
approved these changes
Dec 13, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 210 210
Lines 10750 10749 -1
======================================
- Hits 9639 9638 -1
Misses 1111 1111 |
Borda
force-pushed
the
docs/positive_class
branch
from
28b22ed
to
30a8d57
Compare
Borda
reviewed
Dec 14, 2022
for more information, see https://pre-commit.ci
Borda
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Apply suggestions from code review Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 4ecb62b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1376
Make it more explicit that
1is always considered the positive class in the documentation (since we removedpos_labelargument).Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃