Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: merge conda and full tests #1324

Merged
merged 17 commits into from
Nov 11, 2022
Merged

CI: merge conda and full tests #1324

merged 17 commits into from
Nov 11, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 9, 2022

What does this PR do?

Unify the suits
continues in #1307

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda changed the title CI: merge conda and full tests CI: merge conda and full tests [wip] Nov 9, 2022
@Borda Borda marked this pull request as ready for review November 9, 2022 17:02
@mergify mergify bot requested a review from a team November 9, 2022 17:02
@Borda Borda changed the title CI: merge conda and full tests [wip] CI: merge conda and full tests Nov 9, 2022
@Borda Borda added the test / CI testing or CI label Nov 9, 2022
@Borda Borda added this to the v0.10 milestone Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1324 (9c37cc9) into master (b1b787d) will decrease coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1324   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         195     195           
  Lines       11370   11369    -1     
======================================
- Hits         9857    9856    -1     
  Misses       1513    1513           

@Borda
Copy link
Member Author

Borda commented Nov 11, 2022

let's do the MacOS update in #1307
cc: @justusschock

@mergify mergify bot added the ready label Nov 11, 2022
@Borda Borda merged commit fe55207 into master Nov 11, 2022
@Borda Borda deleted the ci/tests branch November 11, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants