-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: merge conda and full tests #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
changed the title
CI: merge conda and full tests
CI: merge conda and full tests [wip]
Nov 9, 2022
Borda
requested review from
SkafteNicki,
justusschock and
tchaton
as code owners
November 9, 2022 18:05
Borda
changed the title
CI: merge conda and full tests [wip]
CI: merge conda and full tests
Nov 9, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
======================================
- Coverage 87% 87% -0%
======================================
Files 195 195
Lines 11370 11369 -1
======================================
- Hits 9857 9856 -1
Misses 1513 1513 |
carmocca
approved these changes
Nov 9, 2022
justusschock
approved these changes
Nov 10, 2022
SkafteNicki
approved these changes
Nov 10, 2022
Borda
commented
Nov 11, 2022
Borda
commented
Nov 11, 2022
let's do the MacOS update in #1307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unify the suits
continues in #1307
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃