Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration utilities #8558

Closed
wants to merge 46 commits into from
Closed

add migration utilities #8558

wants to merge 46 commits into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 26, 2021

What does this PR do?

Adds migration functions. When a checkpoint gets loaded, we migrate it automatically.

Fixes #9396

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added this to the v1.5 milestone Jul 26, 2021
@awaelchli awaelchli added checkpointing Related to checkpointing feature Is an improvement or enhancement labels Jul 26, 2021
@tchaton tchaton added the priority: 0 High priority task label Jul 29, 2021
@awaelchli awaelchli mentioned this pull request Aug 27, 2021
11 tasks
@awaelchli awaelchli removed the priority: 0 High priority task label Aug 27, 2021
@awaelchli awaelchli mentioned this pull request Sep 9, 2021
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 1, 2021
@awaelchli awaelchli modified the milestones: 1.6, future Mar 27, 2022
@carmocca carmocca added the pl Generic label for PyTorch Lightning package label Aug 26, 2022
@awaelchli awaelchli closed this Aug 26, 2022
@awaelchli awaelchli deleted the feature/migration-utils branch August 26, 2022 17:12
@awaelchli
Copy link
Contributor Author

Closing, there is too little value for this atm and the effort is quite large.

@carmocca
Copy link
Contributor

Do you want to close the linked issue too? Or just dropping this implementation?

@carmocca carmocca removed this from the pl:future milestone Aug 26, 2022
@awaelchli
Copy link
Contributor Author

The linked issue can be kept open for the community if we want.

@awaelchli awaelchli restored the feature/migration-utils branch October 21, 2022 10:43
@awaelchli awaelchli mentioned this pull request Oct 21, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkpoint migration
3 participants