Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs new section #2236

Merged
merged 8 commits into from
Jun 18, 2020
Merged

Docs new section #2236

merged 8 commits into from
Jun 18, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 18, 2020

What does this PR do?

add new section in changelog and fix hr

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Jun 18, 2020
@Borda Borda added this to the 0.8.x milestone Jun 18, 2020
@mergify mergify bot requested a review from a team June 18, 2020 13:40
@SkafteNicki
Copy link
Member

While we are fixing readme, maybe also change the github reference in the bibtex, seems outdated:

@Article​{​falcon2019pytorch​,
  ​title​=​{​PyTorch Lightning​}​,
  ​author​=​{​Falcon, WA​}​,
  ​journal​=​{​GitHub. Note: https://github. com/williamFalcon/pytorch-lightning Cited by​}​,
  ​volume​=​{​3​}​,
  ​year​=​{​2019​}​
}
Should be https://github.com/PyTorchLightning/pytorch-lightning

@Borda Borda marked this pull request as ready for review June 18, 2020 14:41
@mergify mergify bot requested a review from a team June 18, 2020 15:11
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2236 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2236   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5435    5435           
======================================
  Hits         4775    4775           
  Misses        660     660           

@Borda
Copy link
Member Author

Borda commented Jun 18, 2020

@williamFalcon lets merge this one and all new (add new HR in docs) do in followup PR

@williamFalcon williamFalcon merged commit 596a5d7 into master Jun 18, 2020
@Borda Borda deleted the docs/section branch June 18, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants