Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version.info to 2.5.0.dev #20316

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Update version.info to 2.5.0.dev #20316

merged 3 commits into from
Oct 21, 2024

Conversation

rasbt
Copy link
Contributor

@rasbt rasbt commented Oct 3, 2024

This PR increases the version since there have been a bunch of changes/fixes since the last release. This makes it a bit easier to detect which version is currently installed in a system.

Ideally, could we also make a new release (or release candidate) soon @Borda ?


📚 Documentation preview 📚: https://pytorch-lightning--20316.org.readthedocs.build/en/20316/

Copy link
Contributor

github-actions bot commented Oct 3, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/version.info.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.9) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.9) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.9) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, fabric, 3.9) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.9) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.9) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.9) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.9) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.9) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.9) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.9) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/version.info.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/version.info Outdated Show resolved Hide resolved
Co-authored-by: Jirka Borovec <[email protected]>
@t-vi
Copy link
Contributor

t-vi commented Oct 18, 2024

Can we use the PyTorch scheme of 2.5.0a0 though? This will sort before the final 2.5.0 in pip (and other Python standard) versioning.

@Borda
Copy link
Member

Borda commented Oct 18, 2024

Can we use the PyTorch scheme of 2.5.0a0 though? This will sort before the final 2.5.0 in pip (and other Python standard) versioning.

I don't think that we can do 2.5 any time some as we didn't landed any feature since 2.4

@t-vi
Copy link
Contributor

t-vi commented Oct 18, 2024 via email

@rasbt
Copy link
Contributor Author

rasbt commented Oct 21, 2024

@t-vi Do you mean PEP 440? That's a good point, but I think it may not matter anymore with more modern packaging tools. E.g., it looks like the sorting order is correct (the development version coming before the alpha release etc):

from packaging.version import Version

versions = [
    "1.0.0",
    "1.0.1",
    "1.0.0a0",  # Alpha 0 version
    "1.0.0a1",  # Alpha 1 version
    "1.0.0b1",  # Beta version
    "1.0.0rc1", # Release candidate
    "1.0.0.post1",  # Post-release
    "1.0.0.dev1",  # Development version
    "1.0.0.post2",  # Another post-release
]

version_objs = [Version(v) for v in versions]

sorted_versions = sorted(version_objs)

for version in sorted_versions:
    print(version)

prints

1.0.0.dev1
1.0.0a0
1.0.0a1
1.0.0b1
1.0.0rc1
1.0.0
1.0.0.post1
1.0.0.post2
1.0.1

Personally, I find it a bit more natural to have the Gh main branch version named .dev1 (and then switching to a0 when creating a pre-release tag), but I don't have a strong preference.

I totally agree with you though that we should have a pre-release (even if it's just an alpha) out soon so that we can finally update bitsandbytes in LitGPT.

@rasbt
Copy link
Contributor Author

rasbt commented Oct 21, 2024

@Borda

I don't think that we can do 2.5 any time some as we didn't landed any feature since 2.4

Can we do a 2.4.1 please though?

@Borda
Copy link
Member

Borda commented Oct 21, 2024

I don't think that we can do 2.5 any time some as we didn't landed any feature since 2.4

Can we do a 2.4.1 please though?

Sure but that goes from release/stable branch not master...

@rasbt
Copy link
Contributor Author

rasbt commented Oct 21, 2024

Sure but that goes from release/stable branch not master...

Yes, that's a different discussion. For now, could we merge this to have the version in master updated to .dev1 or a0 though so that we can can more easily find out check which version a user is on?

@Borda Borda changed the title Update version.info to 2.4.1.dev1 Update version.info to 2.5.0.dev Oct 21, 2024
@Borda Borda merged commit 06a8d5b into master Oct 21, 2024
39 of 40 checks passed
@Borda Borda deleted the rasbt-patch-1 branch October 21, 2024 15:15
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
@speediedan
Copy link
Contributor

Is there any update on whether a Lightning 2.5 release is planned? My sense is that this release may be skipped but I wanted to ensure that was the case before I issued a Fine-Tuning Scheduler pre-release for 2.5 and focused work on PyTorch 2.6 trunk. Thank you all again for all your contributions!
@Borda @t-vi @lantiga @rasbt

@lantiga
Copy link
Collaborator

lantiga commented Nov 26, 2024

Hey @speediedan, 2.5 is totally coming :) expected in the next 2 weeks
Let us know if you need a specific PR to go in

@speediedan
Copy link
Contributor

Hey @speediedan, 2.5 is totally coming :) expected in the next 2 weeks Let us know if you need a specific PR to go in

Awesome! No specific PR needed at the moment, just needed to know for release planning purposes. I was going to issue a pre-release for users that wanted to use Fine-Tuning Scheduler's experimental Auto FSDP2 plan functionality if no Lightning 2.5 release was planned. Thanks Luca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants