-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version.info to 2.5.0.dev
#20316
Conversation
Co-authored-by: Jirka Borovec <[email protected]>
Can we use the PyTorch scheme of |
I don't think that we can do 2.5 any time some as we didn't landed any feature since 2.4 |
The version format should still use FOOa0 instead of FOO.dev . There is a pep for it and then the versions compare properly.
In terms of features, I would love for litgpt to allow newer bitsandbytes with Ali's recent PR, in 2.4.1 or so.
|
@t-vi Do you mean PEP 440? That's a good point, but I think it may not matter anymore with more modern packaging tools. E.g., it looks like the sorting order is correct (the development version coming before the alpha release etc): from packaging.version import Version
versions = [
"1.0.0",
"1.0.1",
"1.0.0a0", # Alpha 0 version
"1.0.0a1", # Alpha 1 version
"1.0.0b1", # Beta version
"1.0.0rc1", # Release candidate
"1.0.0.post1", # Post-release
"1.0.0.dev1", # Development version
"1.0.0.post2", # Another post-release
]
version_objs = [Version(v) for v in versions]
sorted_versions = sorted(version_objs)
for version in sorted_versions:
print(version) prints
Personally, I find it a bit more natural to have the Gh main branch version named I totally agree with you though that we should have a pre-release (even if it's just an alpha) out soon so that we can finally update bitsandbytes in LitGPT. |
Can we do a 2.4.1 please though? |
Sure but that goes from |
Yes, that's a different discussion. For now, could we merge this to have the version in master updated to .dev1 or a0 though so that we can can more easily find out check which version a user is on? |
2.5.0.dev
Co-authored-by: Jirka Borovec <[email protected]>
Is there any update on whether a Lightning |
Hey @speediedan, 2.5 is totally coming :) expected in the next 2 weeks |
Awesome! No specific PR needed at the moment, just needed to know for release planning purposes. I was going to issue a pre-release for users that wanted to use Fine-Tuning Scheduler's experimental |
This PR increases the version since there have been a bunch of changes/fixes since the last release. This makes it a bit easier to detect which version is currently installed in a system.
Ideally, could we also make a new release (or release candidate) soon @Borda ?
📚 Documentation preview 📚: https://pytorch-lightning--20316.org.readthedocs.build/en/20316/