Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove waiting logic in release workflow #20050

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 5, 2024

What does this PR do?

So far, the release process had a mechanism to wait for a builds/version branch to appear while waiting on the merging of an internal repo. But this was a deadlock for a long time, and now that this internal repo no longer depends on the lightning package, we should remove the waiting logic from the package release workflow.


📚 Documentation preview 📚: https://pytorch-lightning--20050.org.readthedocs.build/en/20050/

@github-actions github-actions bot added ci Continuous Integration dependencies Pull requests that update a dependency file labels Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/store/test.txt.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to requirements/store/test.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli added this to the 2.3.x milestone Jul 5, 2024
@awaelchli awaelchli merged commit 3730e98 into master Jul 5, 2024
47 of 48 checks passed
@awaelchli awaelchli deleted the ci/signaling branch July 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants