Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for legacy checkpoint created with 2.3.1 #20023

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

pl-ghost
Copy link
Contributor

@pl-ghost pl-ghost commented Jun 27, 2024

This is automated addition of created checkpoints with the latest lightning release!

cc @awaelchli @Borda

@pl-ghost pl-ghost added the checkpointing Related to checkpointing label Jun 27, 2024
@pl-ghost pl-ghost requested a review from lantiga as a code owner June 27, 2024 17:51
@pl-ghost pl-ghost added pl Generic label for PyTorch Lightning package tests labels Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 2.0, oldest) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.10, 2.1) success
pl-cpu (macOS-11, lightning, 3.10, 2.2) success
pl-cpu (macOS-14, lightning, 3.10, 2.3) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3) success
pl-cpu (windows-2022, lightning, 3.8, 2.0, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.10, 2.2) success
pl-cpu (windows-2022, lightning, 3.10, 2.3) success
pl-cpu (macOS-11, pytorch, 3.8, 2.0) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.0) success
pl-cpu (windows-2022, pytorch, 3.8, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to tests/legacy/back-compatible-versions.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Jun 27, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51%. Comparing base (b6be13c) to head (3f54b8a).
Report is 74 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b6be13c) and HEAD (3f54b8a). Click for more details.

HEAD has 184 uploads less than BASE
Flag BASE (b6be13c) HEAD (3f54b8a)
python3.10 19 12
cpu 68 24
lightning 40 15
pytest 50 0
examples 9 0
app 9 0
python3.8 12 6
lightning_fabric 10 0
python3.11 20 6
tpu 2 0
gpu 4 0
lightning_app 3 0
pytorch_lightning 10 9
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20023      +/-   ##
==========================================
- Coverage      84%      51%     -33%     
==========================================
  Files         427      419       -8     
  Lines       35505    35352     -153     
==========================================
- Hits        29782    18029   -11753     
- Misses       5723    17323   +11600     

@Borda Borda merged commit 2524864 into master Jun 28, 2024
39 checks passed
@Borda Borda deleted the create-pull-request/patch branch June 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants