Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test for legacy checkpoint created with 2.2.1 #19570

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Adding test for legacy checkpoint created with 2.2.1 #19570

merged 1 commit into from
Mar 4, 2024

Conversation

pl-ghost
Copy link
Contributor

@pl-ghost pl-ghost commented Mar 4, 2024 •
edited by github-actions bot
Loading

This is automated addition of created checkpoints with the latest lightning release!

cc @awaelchli @Borda

@pl-ghost pl-ghost added the checkpointing Related to checkpointing label Mar 4, 2024
@pl-ghost pl-ghost requested a review from lantiga as a code owner March 4, 2024 17:26
@pl-ghost pl-ghost added pl Generic label for PyTorch Lightning package tests labels Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.2) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success ✅

These checks are required after the changes to tests/legacy/back-compatible-versions.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli merged commit 7c7f0ee into master Mar 4, 2024
39 checks passed
@awaelchli awaelchli deleted the create-pull-request/patch branch March 4, 2024 20:20
@mergify mergify bot added the ready PRs ready to be merged label Mar 4, 2024
@awaelchli awaelchli added this to the 2.3 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@Borda Borda

Labels
checkpointing Related to checkpointing pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@pl-ghost @awaelchli @Borda