migrate Data subpackage #19523
migrate Data subpackage #19523
Conversation
tchaton
requested review from
Borda,
carmocca,
ethanwharris,
justusschock,
lantiga and
awaelchli
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685611 | Triggered | Generic High Entropy Secret | fcab3bd | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | fcab3bd | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | fcab3bd | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | fcab3bd | tests/tests_data/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
github-actions
bot
added
ci
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 lightning_app: Tests workflow
These checks are required after the changes to 🟢 lightning_app: Examples
These checks are required after the changes to 🟢 lightning: Store
These checks are required after the changes to 🟢 lightning_app: Docs
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19523 +/- ##
=========================================
Coverage 83% 84%
=========================================
Files 450 424 -26
Lines 38250 34912 -3338
=========================================
- Hits 31893 29212 -2681
+ Misses 6357 5700 -657 |
github-actions
bot
added
docs
* update * update * update * update * Update checkgroup.yml * More * Add note * Labeller should be kept as long as we have the stubs * update * update * update * Apply suggestions from code review * init * ci fix * pin version range * https://www.neptune.ai/ --------- Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>
What does this PR do?
This PR deletes all the files associated to data as the package was moved to a standalone repo: https://github.com/Lightning-AI/litdata
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @tchaton