-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests for PyTorch 2.2.1 #19521
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19521 +/- ##
==========================================
- Coverage 84% 53% -30%
==========================================
Files 450 445 -5
Lines 38253 38155 -98
==========================================
- Hits 31972 20350 -11622
- Misses 6281 17805 +11524 |
What does this PR do?
PyTorch 2.2.1 was released, and our CI is now using it.
We are seeing our xfail-marked tests for PyTorch 2.2 on Windows pass now, leading to a test failure:
https://github.com/Lightning-AI/pytorch-lightning/actions/runs/8020097179/job/21909915929?pr=19518
This PR removes the marks.
cc @Borda @carmocca @justusschock @awaelchli