Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for PyTorch 2.2.1 #19521

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Update tests for PyTorch 2.2.1 #19521

merged 2 commits into from
Feb 23, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 23, 2024

What does this PR do?

PyTorch 2.2.1 was released, and our CI is now using it.
We are seeing our xfail-marked tests for PyTorch 2.2 on Windows pass now, leading to a test failure:
https://github.com/Lightning-AI/pytorch-lightning/actions/runs/8020097179/job/21909915929?pr=19518

This PR removes the marks.

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Feb 23, 2024
@awaelchli awaelchli added this to the 2.2.x milestone Feb 23, 2024
Copy link
Contributor

github-actions bot commented Feb 23, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.10, 2.1) success
pl-cpu (macOS-11, lightning, 3.10, 2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success
pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.10, 2.2) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to tests/tests_pytorch/callbacks/test_spike.py, tests/tests_pytorch/loops/test_prediction_loop.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/serve/test_servable_module_validator.py, tests/tests_pytorch/strategies/launchers/test_multiprocessing.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to tests/tests_pytorch/callbacks/test_spike.py, tests/tests_pytorch/loops/test_prediction_loop.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/serve/test_servable_module_validator.py, tests/tests_pytorch/strategies/launchers/test_multiprocessing.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.11, 2.1) success
fabric-cpu (macOS-11, lightning, 3.11, 2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success
fabric-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/strategies/launchers/test_multiprocessing_integration.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/utilities/test_distributed.py, tests/tests_fabric/utilities/test_spike.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/strategies/launchers/test_multiprocessing_integration.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/utilities/test_distributed.py, tests/tests_fabric/utilities/test_spike.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli changed the title [WIP] Update tests for 2.2.1 [WIP] Update tests for PyTorch 2.2.1 Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #19521 (e424cc0) into master (623ec58) will decrease coverage by 30%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19521      +/-   ##
==========================================
- Coverage      84%      53%     -30%     
==========================================
  Files         450      445       -5     
  Lines       38253    38155      -98     
==========================================
- Hits        31972    20350   -11622     
- Misses       6281    17805   +11524     

@awaelchli awaelchli changed the title [WIP] Update tests for PyTorch 2.2.1 Update tests for PyTorch 2.2.1 Feb 23, 2024
@mergify mergify bot added the ready PRs ready to be merged label Feb 23, 2024
@awaelchli awaelchli merged commit a41528c into master Feb 23, 2024
61 checks passed
@awaelchli awaelchli deleted the tests/torch-221 branch February 23, 2024 18:11
awaelchli added a commit that referenced this pull request Mar 1, 2024
lantiga pushed a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants