Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSVLogger(name: ...) optional str #19518

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Make CSVLogger(name: ...) optional str #19518

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb11c5f
Make `CSVLogger(name: ...)` optional `str`
mwip Feb 23, 2024
4528025
Apply `name: Optional[str]` in fabric; fix typos
mwip Feb 23, 2024
6c9ab82
Merge branch 'master' into 19433_typing_optional_str_in_csv_logger
awaelchli Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lightning/pytorch/loggers/csv_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ class CSVLogger(Logger, FabricCSVLogger):

Args:
save_dir: Save directory
name: Experiment name. Defaults to ``'lightning_logs'``.
name: Experiment name, optional. Defaults to ``'lightning_logs'``. If name is `None`, log
(versions) stored to the save dir directly.
mwip marked this conversation as resolved.
Show resolved Hide resolved
version: Experiment version. If version is not specified the logger inspects the save
directory for existing versions, then automatically assigns the next available version.
prefix: A string to put at the beginning of metric keys.
Expand All @@ -95,7 +96,7 @@ class CSVLogger(Logger, FabricCSVLogger):
def __init__(
self,
save_dir: _PATH,
name: str = "lightning_logs",
name: Optional[str] = "lightning_logs",
mwip marked this conversation as resolved.
Show resolved Hide resolved
version: Optional[Union[int, str]] = None,
prefix: str = "",
flush_logs_every_n_steps: int = 100,
Expand Down
Loading