-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all_gather
docs
#19469
Merged
Merged
Update all_gather
docs
#19469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
justusschock,
lantiga and
Borda
as code owners
February 14, 2024 03:28
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19469 +/- ##
==========================================
- Coverage 84% 53% -30%
==========================================
Files 450 445 -5
Lines 38091 37993 -98
==========================================
- Hits 31814 20272 -11542
- Misses 6277 17721 +11444 |
Borda
approved these changes
Feb 14, 2024
carmocca
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine. If collectives ever land then we could be consistent there and add the compatibility layer in these top-level functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm documenting an inconsistency in
all_gather
between worls_size 1 and > 1 as discussed in #19195. In my opinion it is not worth doing a breaking change to restore the consistency, so I'm documenting this special case instead.Fixes #19195
cc @Borda @carmocca @justusschock @awaelchli