Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix pages on PyPI #18792

Merged
merged 25 commits into from
Oct 13, 2023
Merged

docs: fix pages on PyPI #18792

merged 25 commits into from
Oct 13, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 12, 2023

What does this PR do?

revisited badges and images in package description - one image is missing and badge is not rendered

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18792.org.readthedocs.build/en/18792/

cc @carmocca @Borda @tchaton @justusschock @awaelchli

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Oct 12, 2023
@github-actions
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested a review from lantiga as a code owner October 12, 2023 16:44
@Borda Borda requested a review from ethanwharris as a code owner October 12, 2023 17:55
@github-actions github-actions bot added the ci Continuous Integration label Oct 12, 2023
@Borda Borda added priority: 1 Medium priority task release labels Oct 12, 2023
@Borda Borda added this to the 2.1.x milestone Oct 12, 2023
@Borda
Copy link
Member Author

Borda commented Oct 12, 2023

The MD check takes too long...

@mergify mergify bot added the ready PRs ready to be merged label Oct 12, 2023
@Borda
Copy link
Member Author

Borda commented Oct 13, 2023

mdformat is breaking the Azure badges... hukkin/mdformat#416

@Borda Borda merged commit 367b57e into master Oct 13, 2023
15 checks passed
@Borda Borda deleted the docs/readme branch October 13, 2023 13:58
Borda added a commit that referenced this pull request Nov 2, 2023
(cherry picked from commit 367b57e)
lantiga pushed a commit that referenced this pull request Nov 6, 2023
(cherry picked from commit 367b57e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package priority: 1 Medium priority task ready PRs ready to be merged release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants