-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new update_called
from metrics
#18714
Merged
awaelchli
merged 3 commits into
Lightning-AI:master
from
matsumotosan:metrics/update-called
Oct 6, 2023
Merged
use new update_called
from metrics
#18714
awaelchli
merged 3 commits into
Lightning-AI:master
from
matsumotosan:metrics/update-called
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsumotosan
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
October 4, 2023 12:30
awaelchli
reviewed
Oct 4, 2023
src/lightning/pytorch/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
awaelchli
added
logging
Related to the `LoggerConnector` and `log()`
community
This PR is from the community
labels
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the steps for using the torchmetrics version to determine whether to use the public property or the private property
src/lightning/pytorch/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18714 +/- ##
=========================================
- Coverage 58% 50% -7%
=========================================
Files 428 420 -8
Lines 33481 33338 -143
=========================================
- Hits 19303 16817 -2486
- Misses 14178 16521 +2343 |
awaelchli
approved these changes
Oct 6, 2023
carmocca
approved these changes
Oct 6, 2023
Borda
approved these changes
Oct 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Must be fixed for Lightning-AI/torchmetrics#2141 to pass
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18714.org.readthedocs.build/en/18714/