Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "finished" status code in MLFlowLogger #16340

Merged
merged 5 commits into from
Jan 12, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correction to manage "finished" in status
  • Loading branch information
Forbu authored Jan 11, 2023

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
commit 1d81b5728fb0b1065575fbde8b7ece4eb6b54c1c
2 changes: 2 additions & 0 deletions src/pytorch_lightning/loggers/mlflow.py
Original file line number Diff line number Diff line change
@@ -284,6 +284,8 @@ def finalize(self, status: str = "success") -> None:
status = "FINISHED"
elif status == "failed":
status = "FAILED"
elif status == "finished":
status = "FINISHED"

# log checkpoints as artifacts
if self._checkpoint_callback: