Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default work start method to spawn on MacOS #16089

Merged
merged 10 commits into from
Dec 19, 2022
Merged

Set the default work start method to spawn on MacOS #16089

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cd55d1d
set the default work start method to spawn
awaelchli Dec 16, 2022
adceb49
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 16, 2022
eec11db
Merge branch 'master' into feature/work-spawn-default
awaelchli Dec 18, 2022
efd2558
fix typo
awaelchli Dec 18, 2022
1e10d79
only for darwin
awaelchli Dec 18, 2022
44a69ca
add test
awaelchli Dec 19, 2022
95b5d7d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 19, 2022
de2454e
changelog
awaelchli Dec 19, 2022
a063105
Merge remote-tracking branch 'origin/feature/work-spawn-default' into…
awaelchli Dec 19, 2022
7fb6837
Merge branch 'master' into feature/work-spawn-default
awaelchli Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/lightning_app/components/serve/gradio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ class ServeGradio(LightningWork, abc.ABC):
title: Optional[str] = None
description: Optional[str] = None

_start_method = "spawn"

def __init__(self, *args, **kwargs):
requires("gradio")(super().__init__(*args, **kwargs))
assert self.inputs
Expand Down
3 changes: 0 additions & 3 deletions src/lightning_app/components/serve/python_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ def _get_sample_data() -> Dict[Any, Any]:


class PythonServer(LightningWork, abc.ABC):

_start_method = "spawn"

@requires(["torch"])
def __init__( # type: ignore
self,
Expand Down
3 changes: 1 addition & 2 deletions src/lightning_app/core/work.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ class LightningWork:
)

_run_executor_cls: Type[WorkRunExecutor] = WorkRunExecutor
# TODO: Move to spawn for all Operating System.
_start_method = "spawn" if sys.platform == "win32" else "fork"
_start_method = "spawn"

def __init__(
self,
Expand Down