Add support for colossalai 0.1.11 #15888
Merged
+65
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1SAA
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
awaelchli
added
strategy: colossalai (removed)
awaelchli
reviewed
Dec 5, 2022
|
@tchaton It is a good suggestion. I think I can add some new unit tests. |
awaelchli
approved these changes
Dec 7, 2022
carmocca
approved these changes
Dec 12, 2022
carmocca
changed the title
carmocca
reviewed
Dec 12, 2022
mergify
bot
added
ready
auto-merge was automatically disabled
December 16, 2022 07:39
Head branch was pushed to by a user without write access
carmocca
approved these changes
Dec 16, 2022
carmocca
changed the title
|
The mypy checks are failing: https://github.com/Lightning-AI/lightning/actions/runs/3711224217/jobs/6291426057 |
Co-authored-by: Carlos Mocholí <[email protected]>
…strategy/colossalai
|
seems there are no stable release yet so going to temporarily drop testing in #16122 |
carmocca
added a commit
that referenced
this pull request
Dec 20, 2022
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
carmocca
added a commit
that referenced
this pull request
Dec 20, 2022
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
carmocca
added a commit
that referenced
this pull request
Dec 20, 2022
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
carmocca
added a commit
that referenced
this pull request
Dec 20, 2022
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
carmocca
added a commit
that referenced
this pull request
Dec 20, 2022
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
nicolai86
pushed a commit
that referenced
this pull request
Dec 20, 2022
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the APIs in ColossalAIStrategy for its new version.
Since the API of Gemini in ColossalAI has updated recently, it becames incompatible with Lightning.
For compatibility with the upcoming version 0.1.11, I updated the ColossalAIStrategy.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃