Lazy import tensorboard #15762
Merged
Lazy import tensorboard #15762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
justusschock and
williamFalcon
as code owners
Borda
reviewed
Nov 22, 2022
Borda
reviewed
Nov 22, 2022
| if _TENSORBOARD_AVAILABLE: | ||
| from torch.utils.tensorboard.summary import hparams | ||
| else: | ||
| from tensorboardX.summary import hparams # type: ignore[no-redef] |
There was a problem hiding this comment.
how many times is this called per epoch?
There was a problem hiding this comment.
This was answered in #15762 (comment)
Borda
reviewed
Nov 22, 2022
awaelchli
approved these changes
Nov 22, 2022
akihironitta
approved these changes
Nov 23, 2022
Borda
reviewed
Nov 23, 2022
| _TENSORBOARDX_AVAILABLE = RequirementCache("tensorboardX") | ||
| if TYPE_CHECKING: | ||
| # assumes at least one will be installed when type checking | ||
| if _TENSORBOARD_AVAILABLE: |
There was a problem hiding this comment.
this is opposite what @lantiga said in #15728 (comment) 🦦
Borda
reviewed
Nov 23, 2022
| @@ -109,6 +114,10 @@ def __init__( | |||
| sub_dir: Optional[_PATH] = None, | |||
| **kwargs: Any, | |||
| ): | |||
| if not _TENSORBOARD_AVAILABLE and not _TENSORBOARDX_AVAILABLE: | |||
There was a problem hiding this comment.
this won't happen as TBX is mandatory depenency
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids importing tensorboard unless the logger is used.
Part of #12786
Part of #15662
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @awaelchli @Borda @akihironitta