Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused TPU CI files #15611

Merged
merged 5 commits into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/checkgroup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ subprojects:
- id: "pytorch-lightning: TPU workflow"
paths:
- ".github/workflows/tpu-tests.yml"
- "dockers/base-xla/*"
checks:
- "test-on-tpus"

Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/tpu-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
paths:
- ".github/workflows/tpu-tests.yml"
- "dockers/base-xla/*"
- "requirements/pytorch/*"
- "!requirements/pytorch/docs.txt"
- "src/pytorch_lightning/**"
Expand All @@ -31,7 +32,7 @@ jobs:
if: github.event.pull_request.draft == false
env:
PYTHON_VER: 3.7
timeout-minutes: 100 # should match the timeout in `tpu_test_cases.jsonnet`
timeout-minutes: 100 # should match the timeout in `tpu_workflow.jsonnet`

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -62,9 +63,9 @@ jobs:
PR_NUMBER: ${{ github.event.pull_request.number }}
SHA: ${{ github.event.pull_request.head.sha }}
run: |
python -c "fname = 'dockers/tpu-tests/tpu_test_cases.jsonnet' ; data = open(fname).read().replace('{PYTORCH_VERSION}', '$XLA_VER')
python -c "fname = 'dockers/base-xla/tpu_workflow.jsonnet' ; data = open(fname).read().replace('{PYTORCH_VERSION}', '$XLA_VER')
data = data.replace('{PYTHON_VERSION}', '$PYTHON_VER').replace('{PR_NUMBER}', '$PR_NUMBER').replace('{SHA}', '$SHA') ; open(fname, 'w').write(data)"
cat dockers/tpu-tests/tpu_test_cases.jsonnet
cat dockers/base-xla/tpu_workflow.jsonnet
shell: bash

- uses: google-github-actions/auth@v0
Expand All @@ -80,7 +81,7 @@ jobs:
- name: Deploy cluster
run: |
export PATH=$PATH:$HOME/go/bin
job_name=$(jsonnet -J ml-testing-accelerators/ dockers/tpu-tests/tpu_test_cases.jsonnet | kubectl create -f -)
job_name=$(jsonnet -J ml-testing-accelerators/ dockers/base-xla/tpu_workflow.jsonnet | kubectl create -f -)
job_name=${job_name#job.batch/}
job_name=${job_name% created}
pod_name=$(kubectl get po -l controller-uid=`kubectl get job $job_name -o "jsonpath={.metadata.labels.controller-uid}"` | awk 'match($0,!/NAME/) {print $1}')
Expand Down
37 changes: 0 additions & 37 deletions dockers/tpu-tests/Dockerfile

This file was deleted.

8 changes: 0 additions & 8 deletions dockers/tpu-tests/docker-entrypoint.sh

This file was deleted.