Use _PATH in annotations and convert to str if Path #15560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This minor change adds type annotation for pathlib.Path to some code locations, e.g.
Trainer(default_root_dir: _PATH
.The type
_PATH
which isUnion[str, Path]
is used as it is already declared/used elsewhere.To not break downstream code that expects
str
, the_PATH
args/options are converted tostr
usingos.fspath
.Fixes #15497
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
Writing a test for these small changes doesn't seem useful.
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃