Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_from_checkpoint returns the expected type #15496

Merged
merged 9 commits into from
Nov 4, 2022
Merged

load_from_checkpoint returns the expected type #15496

merged 9 commits into from
Nov 4, 2022

Conversation

dyollb
Copy link
Contributor

@dyollb dyollb commented Nov 3, 2022 •
edited
Loading

What does this PR do?

  • Self/self cannot be used since it requires python 3.11 AFAIK
  • Since it looks like the tests are not type checked, I added a folder under tests for type checking (maybe more will be added)

Fixes #15467

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 3, 2022
@mergify mergify bot added the has conflicts label Nov 3, 2022
@mergify mergify bot removed the has conflicts label Nov 3, 2022
rohitgr7
rohitgr7 reviewed Nov 3, 2022
View reviewed changes
tests/tests_type_checking/test_lightning_module.py Outdated Show resolved Hide resolved
src/pytorch_lightning/core/saving.py Outdated Show resolved Hide resolved
src/pytorch_lightning/core/saving.py Outdated Show resolved Hide resolved
@dyollb dyollb force-pushed the typed_load_from_checkpoint branch from 2cde49f to 5faae27 Compare November 3, 2022 12:42
@dyollb
Copy link
Contributor Author

dyollb commented Nov 3, 2022

The failing test seems to be because of a bug in mypy: https://stackoverflow.com/questions/70083371/can-i-use-experimental-types-from-typing-extensions

@awaelchli awaelchli added code quality community This PR is from the community labels Nov 3, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 3, 2022
awaelchli
awaelchli reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still in favor of the TypeVar for max IDE compatibility

src/pytorch_lightning/core/saving.py Outdated Show resolved Hide resolved
src/pytorch_lightning/core/datamodule.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 4, 2022 15:14
@awaelchli awaelchli merged commit fe8488d into Lightning-AI:master Nov 4, 2022
Borda pushed a commit that referenced this pull request Nov 5, 2022
@dyollb @Borda
load_from_checkpoint returns the expected type (#15496)
bdb7b20 
Co-authored-by: Bryn Lloyd <[email protected]>
(cherry picked from commit fe8488d)
@dyollb dyollb deleted the typed_load_from_checkpoint branch November 6, 2022 20:21
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@dyollb @lexierule
load_from_checkpoint returns the expected type (#15496)
1400881 
Co-authored-by: Bryn Lloyd <[email protected]>
(cherry picked from commit fe8488d)
@awaelchli awaelchli mentioned this pull request Nov 20, 2022
Closed
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 left review comments

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@carmocca carmocca

Labels
code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

MyNet.load_from_checkpoint should return an instance of type MyNet
4 participants
@dyollb @awaelchli @carmocca @rohitgr7