Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump typing-extensions #15405

Merged
merged 1 commit into from
Oct 31, 2022
Merged

bump typing-extensions #15405

merged 1 commit into from
Oct 31, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 28, 2022

What does this PR do?

Some tests are failing in #14517
see: https://github.com/Lightning-AI/lightning/actions/runs/3348600827/jobs/5547833575

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added the ci Continuous Integration label Oct 28, 2022
@Borda Borda added this to the v1.8.x milestone Oct 28, 2022
@Borda Borda enabled auto-merge (squash) October 28, 2022 22:17
@mergify mergify bot added the ready PRs ready to be merged label Oct 30, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@justusschock justusschock disabled auto-merge October 31, 2022 13:37
@justusschock justusschock enabled auto-merge (squash) October 31, 2022 13:37
@lantiga lantiga disabled auto-merge October 31, 2022 13:52
@lantiga lantiga merged commit b4c1a41 into master Oct 31, 2022
@lantiga lantiga deleted the ci/ext-ver branch October 31, 2022 13:52
@awaelchli awaelchli modified the milestones: v1.8.x, v1.8 Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants