Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use torch.testing.assert_close everywhere #15031

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Oct 7, 2022

What does this PR do?

In the PR #13123 (comment), we introduced a convention of checking for version to use torch-version-appropriate function for checking closeness of tensors. However, according to pytorch/pytorch#61844, the torch.testing.assert_close was introduced in 1.9, therefore we should be able to call it in all versions we currently support.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@otaj otaj added ci Continuous Integration tests pl Generic label for PyTorch Lightning package labels Oct 7, 2022
@otaj otaj added this to the pl:1.7.x milestone Oct 7, 2022
@otaj otaj self-assigned this Oct 7, 2022
@carmocca carmocca removed the ci Continuous Integration label Oct 7, 2022
@otaj otaj enabled auto-merge (squash) October 7, 2022 14:58
@otaj otaj merged commit 7e518ca into master Oct 7, 2022
@otaj otaj deleted the ci/remove_unnecessary_allclose branch October 7, 2022 14:59
@mergify mergify bot added the ready PRs ready to be merged label Oct 7, 2022
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
remove unnecessary version check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants