Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Lite Precision into PL #14798

Merged
merged 37 commits into from
Sep 22, 2022
Merged

Integrate Lite Precision into PL #14798

merged 37 commits into from
Sep 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 20, 2022

What does this PR do?

Follow up to #14735
The PL base class PrecisionPlugin is now based on the Lite Precision plugin.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @carmocca @awaelchli @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 20, 2022
@awaelchli awaelchli added the fabric lightning.fabric.Fabric label Sep 20, 2022
@awaelchli awaelchli self-assigned this Sep 20, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 20, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 22, 2022 09:40
@awaelchli awaelchli disabled auto-merge September 22, 2022 09:40
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 22, 2022
@Borda Borda requested a review from carmocca September 22, 2022 10:43
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@Borda Borda enabled auto-merge (squash) September 22, 2022 10:44
@awaelchli awaelchli disabled auto-merge September 22, 2022 10:52
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 22, 2022 14:08
@awaelchli awaelchli merged commit dd2a1c5 into master Sep 22, 2022
@awaelchli awaelchli deleted the lite/integrate-precision branch September 22, 2022 14:51
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants