Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairscale import updates #14721

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Fairscale import updates #14721

merged 6 commits into from
Sep 29, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 15, 2022

What does this PR do?

Follow up to #14675
Suggested by @carmocca

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @carmocca @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 15, 2022
@awaelchli awaelchli marked this pull request as ready for review September 15, 2022 11:59
@awaelchli awaelchli added refactor fabric lightning.fabric.Fabric labels Sep 15, 2022
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.8 Sep 15, 2022
@awaelchli awaelchli self-assigned this Sep 15, 2022
@awaelchli awaelchli added the priority: 2 Low priority task label Sep 15, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 16, 2022
@awaelchli awaelchli requested a review from otaj as a code owner September 17, 2022 22:12
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 17, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 19, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 19, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@Borda Borda enabled auto-merge (squash) September 22, 2022 10:14
@Borda Borda merged commit d8e90f6 into master Sep 29, 2022
@Borda Borda deleted the lite/fairscale-imports branch September 29, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 2 Low priority task ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants