Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Upload File endpoint #14703

Merged
merged 21 commits into from
Sep 19, 2022
Merged

Introduce Upload File endpoint #14703

merged 21 commits into from
Sep 19, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 14, 2022

What does this PR do?

This PR enables us to get rid of the File Server to upload files to the Shared Storage and reduce cost of the Training Studio Cloud App.

Furthermore, I made some tests and it seems the async mechanism enables to keep fetching the Rest API while uploading a file.

Screen.Recording.2022-09-15.at.09.50.28.mov

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 14, 2022
@tchaton tchaton marked this pull request as ready for review September 15, 2022 07:23
@tchaton tchaton added this to the app:0.7 milestone Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #14703 (0a525b8) into master (a5b0f8b) will increase coverage by 1%.
The diff coverage is 35%.

@@            Coverage Diff            @@
##           master   #14703     +/-   ##
=========================================
+ Coverage      84%      85%     +1%     
=========================================
  Files         395      328     -67     
  Lines       28813    25804   -3009     
=========================================
- Hits        24102    21880   -2222     
+ Misses       4711     3924    -787     

src/lightning_app/core/api.py Outdated Show resolved Hide resolved
src/lightning_app/core/api.py Outdated Show resolved Hide resolved
tests/tests_app/core/test_lightning_api.py Outdated Show resolved Hide resolved
tests/tests_app/core/test_lightning_api.py Outdated Show resolved Hide resolved
@awaelchli
Copy link
Contributor

Is it needed to add docs anywhere for this?

@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2022
@tchaton tchaton requested a review from lantiga as a code owner September 16, 2022 14:28
Copy link
Contributor

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just one question

src/lightning_app/core/api.py Show resolved Hide resolved
@lexierule lexierule merged commit c926e10 into master Sep 19, 2022
@lexierule lexierule deleted the reduce_cost branch September 19, 2022 13:26
krshrimali pushed a commit that referenced this pull request Sep 19, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
krshrimali pushed a commit that referenced this pull request Sep 19, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
krshrimali pushed a commit that referenced this pull request Sep 19, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
krshrimali pushed a commit that referenced this pull request Sep 19, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
krshrimali pushed a commit that referenced this pull request Sep 19, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
lexierule pushed a commit that referenced this pull request Sep 19, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants