-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Upload File endpoint #14703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Sep 14, 2022
tchaton
requested review from
awaelchli,
manskx and
hhsecond
as code owners
September 15, 2022 07:23
Codecov Report
@@ Coverage Diff @@
## master #14703 +/- ##
=========================================
+ Coverage 84% 85% +1%
=========================================
Files 395 328 -67
Lines 28813 25804 -3009
=========================================
- Hits 24102 21880 -2222
+ Misses 4711 3924 -787 |
awaelchli
approved these changes
Sep 15, 2022
Is it needed to add docs anywhere for this? |
ethanwharris
approved these changes
Sep 15, 2022
kaushikb11
approved these changes
Sep 16, 2022
kaushikb11
reviewed
Sep 16, 2022
hhsecond
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Just one question
krshrimali
pushed a commit
that referenced
this pull request
Sep 19, 2022
* update * update * update * update * update * update * update * update * update * update
krshrimali
pushed a commit
that referenced
this pull request
Sep 19, 2022
* update * update * update * update * update * update * update * update * update * update
krshrimali
pushed a commit
that referenced
this pull request
Sep 19, 2022
* update * update * update * update * update * update * update * update * update * update
krshrimali
pushed a commit
that referenced
this pull request
Sep 19, 2022
* update * update * update * update * update * update * update * update * update * update
krshrimali
pushed a commit
that referenced
this pull request
Sep 19, 2022
* update * update * update * update * update * update * update * update * update * update [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
lexierule
pushed a commit
that referenced
this pull request
Sep 19, 2022
* update * update * update * update * update * update * update * update * update * update [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
* update * update * update * update * update * update * update * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables us to get rid of the File Server to upload files to the Shared Storage and reduce cost of the Training Studio Cloud App.
Furthermore, I made some tests and it seems the async mechanism enables to keep fetching the Rest API while uploading a file.
Screen.Recording.2022-09-15.at.09.50.28.mov
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃