Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix horovod tests #14382

Merged
merged 19 commits into from
Aug 25, 2022
Merged

[CI] fix horovod tests #14382

merged 19 commits into from
Aug 25, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Aug 24, 2022

What does this PR do?

Horovod tests are failing with mysterious errors

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda @awaelchli @justusschock @kaushikb11

@otaj otaj added bug Something isn't working ci Continuous Integration strategy: horovod (removed) accelerator: cuda Compute Unified Device Architecture GPU labels Aug 24, 2022
@otaj otaj added this to the pl:1.7.x milestone Aug 24, 2022
@otaj otaj self-assigned this Aug 24, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 24, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 25, 2022
@otaj otaj added priority: 0 High priority task pl Generic label for PyTorch Lightning package labels Aug 25, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 25, 2022
@otaj
Copy link
Contributor Author

otaj commented Aug 25, 2022

For completeness sake of what broke - Horovod tests were broken due to NCCL, which from 2.12.7 broke when linked against dynamic libcudart - NVIDIA/nccl#658

The solution is to forcefully downgrade to the last working version 2.11.4, which will then be picked up by Horovod when compiling.

Added couple small improvements to how GPU tests are being run (and the environment being prepared)

@otaj
Copy link
Contributor Author

otaj commented Aug 25, 2022

This will be ready to merge once Docker images are built and pushed to dockerhub

@otaj otaj marked this pull request as ready for review August 25, 2022 12:06
@mergify mergify bot added the ready PRs ready to be merged label Aug 25, 2022
.azure/gpu-tests.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@otaj otaj enabled auto-merge (squash) August 25, 2022 13:27
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 25, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 25, 2022
@otaj otaj disabled auto-merge August 25, 2022 15:27
@otaj otaj enabled auto-merge (squash) August 25, 2022 15:27
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot removed the ready PRs ready to be merged label Aug 25, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 25, 2022
@otaj otaj merged commit 1ae14ca into master Aug 25, 2022
@otaj otaj deleted the ci/dont_reinstall_requirements branch August 25, 2022 17:30
rohitgr7 pushed a commit that referenced this pull request Aug 31, 2022
lexierule pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: cuda Compute Unified Device Architecture GPU bug Something isn't working ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged strategy: horovod (removed)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants