Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert wandb Run when mode="disabled" #14112

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

gautierdag
Copy link
Contributor

@gautierdag gautierdag commented Aug 9, 2022

What does this PR do?

This PR fixes #14021 which is caused by a bug introduced by the typing PR (#13483) which asserted that the wandb run object be a Run type and therefore breaks when mode="disabled" is used as wandb then uses the RunDisabled type. Unfortunately since our tests mock wandb, this behaviour was not tested against.

The fix is simply to allow for the RunDisabled object to be set under our logger _experiment attribute.

I've confirmed that the mock code in #14021 passes with this fix.

Fixes #14021

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 9, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Aug 9, 2022
@carmocca carmocca added bug Something isn't working logger: wandb Weights & Biases labels Aug 9, 2022
@carmocca carmocca added the community This PR is from the community label Aug 9, 2022
@carmocca carmocca self-assigned this Aug 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2022
@mergify mergify bot requested a review from a team August 9, 2022 11:50
@awaelchli awaelchli merged commit 56abd60 into Lightning-AI:master Aug 9, 2022
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community logger: wandb Weights & Biases pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WandbLogger throws error with mode="disabled" (pytorch lightning 1.7)
4 participants