Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax docker requirement #14009

Merged
merged 4 commits into from
Aug 10, 2022
Merged

relax docker requirement #14009

merged 4 commits into from
Aug 10, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 3, 2022

What does this PR do?

Attempt to use a version range instead of one fixed version for wider adoption

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added the ci Continuous Integration label Aug 3, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 3, 2022
@mergify mergify bot added the has conflicts label Aug 3, 2022
@Borda Borda requested review from hhsecond and manskx August 4, 2022 15:56
@mergify mergify bot added the has conflicts label Aug 5, 2022
@mergify mergify bot removed the has conflicts label Aug 8, 2022
@Borda Borda self-assigned this Aug 8, 2022
@Borda Borda added this to the all:next milestone Aug 8, 2022
@Borda Borda enabled auto-merge (squash) August 10, 2022 16:47
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Aug 10, 2022
@Borda Borda modified the milestones: all:next, app:0.6 Aug 10, 2022
@Borda Borda merged commit 3966f95 into master Aug 10, 2022
@Borda Borda deleted the req/docker branch August 10, 2022 17:38
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ci Continuous Integration ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants