-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename GPUAccelerator to CUDAAccelerator #13636
Conversation
68ef8c7
to
3e58f9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Should we preserve the git history with "rebase&merge"? (If we do, will need to clean up the commits)
@akihironitta wouldnt we just squash merge it? That should be fine, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @akihironitta !
we should do rebase and merge
with 2 commits to preserve the git history. squash and merge
will not keep it.
8124087
to
9f19717
Compare
9f19717
to
d630a2c
Compare
d630a2c
to
3247b1f
Compare
What does this PR do?
As discussed in #13102 this renames the current GPUAccelerator to CUDAAccelerator.
Introduces
strategy='cuda'
but retainsstrategy='gpu'
for this PR temporarilyIn a follow-up, I will re-route
accelerator='gpu'
to support cuda and mps devices (as also discussed in #13102 )Does your PR introduce any breaking changes? If yes, please list them.
Yes, deprecates the current GPU Accelerator
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @kaushikb11 @akihironitta