Fixed step variable sent to loggers to keep it consistent with trainer.global_step
#13397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated step to trainer.global_step - 1 to make it 0 based indexing
manangoel99
requested review from
williamFalcon,
Borda,
SeanNaren,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
Borda
approved these changes
Jun 24, 2022
rohitgr7
suggested changes
Jun 24, 2022
| @@ -99,7 +99,7 @@ def log_metrics(self, metrics: _OUT_DICT, step: Optional[int] = None) -> None: | |||
| if step is None: | |||
| # added metrics for convenience | |||
| scalar_metrics.setdefault("epoch", self.trainer.current_epoch) | |||
| step = self.trainer.fit_loop.epoch_loop._batches_that_stepped | |||
| step = self.trainer.global_step - 1 | |||
There was a problem hiding this comment.
this isn't BC if multiple optimizers are used.
similar issue: #12274
we need to come up with a better solution.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
|
fixing it here: #13467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR changes the
stepvariable being sent tolog_metricstotrainer.global_stepso that it stays consistent while resuming runsFixes #13163
Does your PR introduce any breaking changes? If yes, please list them.
NNone
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃