Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run main progress bar independent of val progress bar in TQDMProgressBar #12563

Merged
merged 8 commits into from
Apr 11, 2022
Merged

Run main progress bar independent of val progress bar in TQDMProgressBar #12563

merged 8 commits into from
Apr 11, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 1, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes some issues with tqdm progress bar. Explained in comments

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @rohitgr7

@rohitgr7 rohitgr7 added progress bar: tqdm bug Something isn't working labels Apr 1, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone Apr 1, 2022
@rohitgr7 rohitgr7 changed the title Run main progress bar independent of val progress bar Run main progress bar independent of val progress bar in TQDMProgressBar Apr 1, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review April 1, 2022 10:38
@rohitgr7 rohitgr7 requested a review from carmocca April 1, 2022 12:22
@mergify mergify bot added the has conflicts label Apr 2, 2022
@rohitgr7 rohitgr7 mentioned this pull request Apr 5, 2022
Merged
12 tasks
carmocca
carmocca approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot removed the has conflicts label Apr 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2022
awaelchli
awaelchli reviewed Apr 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) April 11, 2022 09:06
@rohitgr7 @awaelchli
Update CHANGELOG.md
6051014 
Co-authored-by: Adrian Wälchli <[email protected]>
krshrimali
krshrimali approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rohitgr7 rohitgr7 merged commit f4883d6 into master Apr 11, 2022
@rohitgr7 rohitgr7 deleted the fix/tqdm_val_main branch April 11, 2022 13:38
rohitgr7 added a commit that referenced this pull request Apr 12, 2022
@rohitgr7 @carmocca
Run main progress bar independent of val progress bar in `TQDMProgres…
527e15c 
…sBar` (#12563)

Co-authored-by: carmocca <[email protected]>
lexierule pushed a commit that referenced this pull request Apr 13, 2022
@rohitgr7 @carmocca @lexierule
Run main progress bar independent of val progress bar in `TQDMProgres…
6aca974 
…sBar` (#12563)

Co-authored-by: carmocca <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@krshrimali krshrimali krshrimali approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working progress bar: tqdm ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@rohitgr7 @awaelchli @carmocca @krshrimali