-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Plugins doc #12440
Merged
Merged
Update Plugins doc #12440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
force-pushed
the
update/plugins_doc
branch
from
March 25, 2022 08:58
ee89c91
to
83c2def
Compare
kaushikb11
requested review from
edenlightning,
tchaton,
Borda and
awaelchli
as code owners
March 29, 2022 05:43
rohitgr7
force-pushed
the
update/plugins_doc
branch
from
March 29, 2022 08:20
426cb06
to
6ce3a1e
Compare
rohitgr7
approved these changes
Mar 29, 2022
kaushikb11
force-pushed
the
update/plugins_doc
branch
from
March 29, 2022 08:52
16da186
to
426cb06
Compare
justusschock
approved these changes
Mar 29, 2022
akihironitta
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Should we update these occurrences of "training type plugin", too?
$ grep -rnIi "training type" docs/source
...
docs/source/common/trainer.rst:1451:Supports passing different training strategies with aliases (ddp, ddp_spawn, etc) as well as custom training type plugins.
docs/source/common/trainer.rst:1461:.. note:: Additionally, you can pass your custom training type plugins to the ``strategy`` argument.
kaushikb11
requested review from
williamFalcon,
SeanNaren and
carmocca
as code owners
March 29, 2022 09:45
tchaton
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Plugins doc with the latest v1.6 changes
also fixes: #12492 and replace training type instances with strategy.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @rohitgr7 @justusschock @kaushikb11 @awaelchli @akihironitta @ananthsub