Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal teardown outside main thread #11124

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 17, 2021

What does this PR do?

Fixes #11118

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda

@awaelchli awaelchli added the bug Something isn't working label Dec 17, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Dec 17, 2021
@tchaton tchaton marked this pull request as ready for review December 17, 2021 07:54
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@mergify mergify bot added the ready PRs ready to be merged label Dec 17, 2021
@mergify mergify bot requested a review from a team December 17, 2021 11:22
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #11124 (eb82410) into master (4ee01b7) will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #11124   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16502    16502           
=======================================
  Hits        15173    15173           
  Misses       1329     1329           

@carmocca carmocca merged commit 6582249 into master Dec 17, 2021
@carmocca carmocca deleted the bugfix/teardown-signal branch December 17, 2021 13:12
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError('signal only works in main thread') messages back for wand sweeps in v1.5.6
4 participants