Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the evaluation loop outputs in the loop #10928

Merged
merged 15 commits into from
Dec 17, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 3, 2021

What does this PR do?

Follow-up to #10810 and #10923

See comments in code for an overview of the changes

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @akihironitta @carmocca @edward-io @ananthsub @ninginthecloud

@carmocca carmocca added refactor logging Related to the `LoggerConnector` and `log()` loops Related to the Loop API labels Dec 3, 2021
@carmocca carmocca added this to the 1.6 milestone Dec 3, 2021
@carmocca carmocca self-assigned this Dec 3, 2021
Base automatically changed from refactor/sort-dataloader-idx-eval-logic to master December 3, 2021 20:01
@carmocca carmocca mentioned this pull request Dec 3, 2021
11 tasks
@mergify mergify bot added the has conflicts label Dec 4, 2021
@mergify mergify bot removed the has conflicts label Dec 6, 2021
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@mergify mergify bot added the ready PRs ready to be merged label Dec 15, 2021
@carmocca
Copy link
Contributor Author

@tchaton this needs your review :)

@carmocca carmocca enabled auto-merge (squash) December 16, 2021 17:12
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carmocca, some investigation required around add_dataloader_idx=False. I added a test.

@mergify mergify bot removed the ready PRs ready to be merged label Dec 17, 2021
@tchaton tchaton self-requested a review December 17, 2021 12:24
@mergify mergify bot added the ready PRs ready to be merged label Dec 17, 2021
@carmocca carmocca merged commit 5956a07 into master Dec 17, 2021
@carmocca carmocca deleted the refactor/optimize-epoch-eval-results branch December 17, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging Related to the `LoggerConnector` and `log()` loops Related to the Loop API ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants